On Thu, Oct 9, 2014 at 1:36 PM, Kirill Yukhin <kirill.yuk...@gmail.com> wrote:
> Hello,
> This patch further extends maxmin patterns.

You didn't update <Subject> field ;)

> Bootstrapped.
> AVX-512* tests on top of patch-set all pass
> under simulator.
>
> Is it ok for trunk?
>
> gcc/
>         * config/i386/sse.md
>         (define_insn "*<code><mode>3_finite<mask_name><round_saeonly_name>"):
>         Fix pattern conditions order.

No, not yet. As recommended earlier, this change should be part of a
later cleanup patch. Do not mix functional changes and cleanups
together, it makes review and eventual bisections harder.

>         (define_insn "*sse4_1_<code><mode>3<mask_name>"): Add masking.
>         (define_insn "*sse4_1_<code><mode>3<mask_name>"0: Ditto.

OK without the part, mentioned above.

Thanks,
Uros.

Reply via email to