On Tue, Oct 07, 2014 at 10:03:26AM -0600, Tom Tromey wrote: > >>>>> "Marek" == Marek Polacek <pola...@redhat.com> writes: > > Marek> [CCing java-patches now] > Marek> Java testsuite breaks with -std=gnu11 as a default and/or with > Marek> -Wimplicit-function-declaration on > > I don't recall how one gets warnings when compiling this generated code, > but if it is generally possible then I think this:
I'm not sure I understand, but this piece of code gets compiled when running the libjava testsuite. And when the warning triggers, we get many fails. > Marek> + if (indirect) > Marek> + fprintf (stream, "extern void JvRunMainName ();\n"); > Marek> + else > Marek> + fprintf (stream, "extern void JvRunMain ();\n"); > > ... will fail with -Wstrict-prototypes, since in C those should > read "(void)" rather than "()". > > If it's not possible then no big deal. I saw declarations of JvRunMain{,Name} with no parameters and with some parameters. So I decided to make it prototype-less function declaration for now. I think we don't have to worry about -Wstrict-prototypes for now. Marek