On Wed, Sep 24, 2014 at 10:49 AM, Kirill Yukhin <kirill.yuk...@gmail.com> wrote:
> Hello,
> Patch in the bottom adds support for pd2dq and dq2pd
> conversions.
>
> Bootstrapped.
> AVX-512* tests on top of patch-set all pass
> under simulator.
>
> Is it ok for trunk?
>
> gcc/
>         * config/i386/i386.c
>         (avx512f_ufix_notruncv8dfv8si_mask_round): Rename to ...
>         (ufix_notruncv8dfv8si2_mask_round): this.

(ufix_notruncv8dfv8si2_mask_round): ... this.

>         * config/i386/sse.md
>         (define_insn "avx512f_cvtdq2pd512_2): Update TARGET check.
>         (define_insn "avx_cvtdq2pd256_2"): Add EVEX version.
>         (define_insn "sse2_cvtdq2pd<mask_name>"): Add masking.
>         (define_insn "avx_cvtpd2dq256<mask_name>"): Ditto.
>         (define_expand "sse2_cvtpd2dq"): Delete.
>         (define_insn "sse2_cvtpd2dq<mask_name>"): Add masking.
>         (define_insn "avx512f_ufix_notruncv8dfv8si<mask_name><round_name>"):
>         Delete.
>         (define_mode_attr pd2udqsuff): New.
>         (define_insn
>         "ufix_notrunc<mode><si2dfmodelower>2<mask_name><round_name>"): Ditto.
>         (define_insn "ufix_notruncv2dfv2si2<mask_name>"): Ditto.
>         (define_insn "*avx_cvttpd2dq256_2"): Delete.
>         (define_expand "sse2_cvttpd2dq"): Ditto.
>         (define_insn "sse2_cvttpd2dq<mask_name>"): Add masking.

You didn't mention following no-op change (in two places):

> -         (match_operand:V2SI 2 "const0_operand")))]
> +         (const_vector:V2SI [(const_int 0) (const_int 0)])))]

OK with the updated ChangeLog.

Thanks,
Uros.

Reply via email to