On Wed, Sep 24, 2014 at 12:01:13PM +0200, Jakub Jelinek wrote:
> > - if (!__lhs_local && !__lhs_local)
> > + if (!__lhs_local && !__rhs_local)
> > std::swap(_M_word, __rhs._M_word);
> > else
> > {
>
> Wouldn't this be something for a (non-Wall?) warning?
> I mean if && or || contains the same conditions, perhaps we should
> warn.
Yeah, I think it'd make sense to warn. I don't think we have an
option for this (-Wlogical-op does something little bit different).
Hence:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63357
Marek
