On Thu, Sep 11, 2014 at 03:28:02PM +0400, Ilya Verbin wrote: > I would like to start merging offloading-related patches from gomp-4_0-branch > to trunk. > This is the first patch (from r202620), which adds a splay tree and memory > mapping to libgomp. > I removed temporarily device 257 from it. Bootstrapped and regtested on > x86_64-linux.
I think it is not useful to split patches on in which sequence they were added to the tree. I'd prefer patches for functional parts for the differences between trunk and corresponding offloading branch. So, one patch should be all the libgomp changes except for addition of plugins, another one generic middle-end changes, then the libmicoffload support library, then libgomp plugin for Intel MIC and finally rest of Intel MIC enablements. E.g. the patch you've posted contains tons of FIXMEs that really shouldn't make into the trunk, not even short lived. Jakub