On Wed, Sep 10, 2014 at 12:09:25PM +0400, Yury Gribov wrote: > The patch caused a lively debate with Segher who wanted .local.vimrc to > not be enabled > by default.
No, that is not what I said. I am saying it is very anti-social to make people's editor behave differently from what they are used to. Wars have been started for much less. But there are more problems with your approach. First, you are encouraging the use of a plugin that is a gaping wide security hole. I do not think GCC should encourage this. Secondly, this is a very poor imitation of the mechanism Vim has for dealing with filetypes, namely, ftplugins. > We basically have two options: > 1) put .local.vimrc to root (just like .dir-locals.el config for Emacs) > 2) put both .local.vimrc and .dir-locals.el to contrib and add Makefile > targets > to create symlinks in root folder per user's request As I said before, Emacs is not Vim. The Emacs dir-locals file simply configures some settings for files with certain major modes in that dir. For example, ours says that c-mode files should use GNU style. This is quite harmless, and probably what most Emacs users want. Your script on the other hand does something totally different: it overrides a bunch of settings the user has made elsewhere. [Snipped some overly optimistic stuff about this all increasing the quality of posted patches. Hint: the most frequently made formatting error is forgetting to put two spaces at the end of a sentence. Which this script does not handle at all (I'm not saying it should, it is hard to do reliably). The patch itself however does introduce another one of these.] Segher
