On 27 August 2014 22:39, Siva Chandra wrote: > The attached patch addresses Jonathan Wakely's comments on the > previous version of the patch: > https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02426.html > > On Tue, Aug 26, 2014 at 10:58 AM, Jonathan Wakely <jwak...@redhat.com> wrote: >> Shouldn't there be a change to python/Makefile.am so that xmethods.py >> gets installed alongside printers.py? Otherwise you can use these new >> xmethods in the libstdc++ testssuite, but they're not available to >> users. > > Ah, sorry I missed that. Added in the attached patch.
Great, I'll try this new version tomorrow. >> I'd also expect something to call the register_libstdcxx_xmethods >> function automatically, as in the attached patch, although this >> doesn't work for me. > > gdb.xmethod is a module. Hence, hasattr(gdb, 'xmethod') in your > suggestion will not return True. I have modified this in the attached > patch to something which should work. OK thanks. > I had something in hook.in in my very first patch but Tom Tromey said > it was not required anymore: > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02405.html Interesting, I wonder how they should have been found then. I think I did test with the files installed, but they weren't used. I'll test again with the new patch.
