Hi! On Wed, 13 Aug 2014 22:41:47 +0200, Tobias Burnus <bur...@net-b.de> wrote: > Cesar Philippidis wrote: > > According to section 2.6.1 in the openacc spec, fortran loop variables > > should be implicitly private like in openmp. This patch does just so. > > Makes sense. Looking at the patch, I wonder whether the context is > properly handled when mixing OpenMP and OpenACC. I have the feeling that > one then might end up using the OpenACC context when one should use the > OpenMP context. However, I have not fully followed the program flow. For > instance, would something like > > !$oacc parallel > !$omp simd private(i) reduction(+:c) > do i = 1, n > ... > end do > > be properly handled?
While that isn't something we're currently focussing on supporting, my intuition tells me that there shouldn't be a separate oacc_current_ctx, and omp_current_ctx should be used instead for OpenACC contexts, too. (If you guys agree, don't let fixing that hold up the patch as posted.) Grüße, Thomas
pgpaBODbFSnoJ.pgp
Description: PGP signature
