On Aug 11, 2014, at 2:58 PM, Janis Johnson <janis_john...@mentor.com> wrote: > Two tests in gcc.target/arm add options that conflict with thumb1 > multilib flags; skip them. Tested with arm-none-linux-gnu for mainline > and 4.9 for a variety of multilib flags. > > OK for mainline and 4.9 branch?
So, my take is you can self-review things like this if you would like. Doesn’t look controversial and likely you understand the issues better than most. Ok. Nit, if you discover a way to figure out incompatible options, it would be nicer to use it. The usual gcc rules are, last option wins, which generally precludes noticing conflicting options. I only mention this here, in case people want to contemplate conflicting options.
