On Jul 14, 2014, at 8:05 PM, Steven Bosscher <stevenb....@gmail.com> wrote:
> On Mon, Jul 14, 2014 at 6:12 AM, Maxim Kuvyrkov wrote:
>> Hi,
>>
>> This patch fixes 2 of the [several] problems in rank_for_schedule heuristics
>> for SCHED_PRESSURE_MODEL. SCHED_PRESSURE_MODEL is used for first scheduling
>> pass in ARM backend by default.
>>
>> The first one is when INSN_TICK of both instructions are equal, and
>> rank_for_schedule returns a "tie" result, even though there are more
>> heuristics down the path to break the tie.
>>
>> The second one is to account for the fact that model_index() of two
>> instructions is meaningful only when both instructions are in the current
>> basic block.
>>
>> Bootstrapped and tested on {x86_64,arm,aarch64}-linux.
>>
>> OK to apply?
>
> s/INSN_BB/BLOCK_FOR_INSN/
That would be a mistake, see definition of INSN_BB in sched-int.h. Scheduler
uses its own basic block numbering.
>
> OK with that change.
I assume OK without the change?
Thank you,
--
Maxim Kuvyrkov
www.linaro.org
