On Wed, Jul 9, 2014 at 12:50 AM, Jan Hubicka <hubi...@ucw.cz> wrote:
>> With the patch, GCC on AIX now responds that "ifunc" is supported.
>> The C and C++ attr-ifunc testcases now run and fail.
>
> This is unexpected. I am testing version of the patch with
>
> if (lookup_attribute ("ifunc", DECL_ATTRIBUTES (n->decl)))
> return false;
>
> added to beggining of rs6000_declare_alias. The problem here is that ifunc is
> dealt with as an alias and becuase we output aliases ourselves, we skip the
> sanity checking done in do_assemble_alias. I think that checking is way too
> late, will look into moving it earlier.
>
> I also checked that we won't skip other useful sanity checking there. (other
> one is
> weakref that we already know to not output in the new way)
>
> Honza
>>
>> g++.dg/ipa/devirt-10 and devirt-15 now fail.
>>
>> Otherwise, the results look very good.
Hi, Honza
Other than those issues, the results generally look good. If you can
correct the patch so that it does not avoid relevant sanity checks, it
should be ready to merge.
Thanks, David
