Hi Yi, 1) please add comments before new functions as documentation -- follow the coding style guideline 2) missing documenation on the new flags (pointed out by Gerald) 3) Please refactor the check code in afdo_calculate_branch_prob into a helper function
4) the change log is not needed for google branches, but if provided, the format should follow the style guide (e.g, function name in () ). David On Fri, Jun 27, 2014 at 11:07 AM, Yi Yang <ahyan...@google.com> wrote: > Hi, > > This patch adds an option. When the option is enabled, GCC will add a > record about it in an elf section called > ".gnu.switches.text.branch.annotation" for every branch. > > gcc/ > > 2014-06-27 Yi Yang <ahyan...@google.com> > > * auto-profile.c: Main comparison and reporting logic. > * cfg-flags.def: Add an extra flag representing an edge's > probability is predicted by annotations. > * predict.c: Set up the extra flag on an edge when appropriate. > * common.opt: Add an extra GCC option to turn on this report mechanism
