On Mon, Jun 2, 2014 at 10:26 AM, Dehao Chen <de...@google.com> wrote: > Just tried with Teresa's patch, the ICE in > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61384 is not resolved.
I will take a look to see why this wasn't fixed by my profile redesign. Teresa > > Dehao > > On Mon, Jun 2, 2014 at 9:45 AM, Jeff Law <l...@redhat.com> wrote: >> On 06/02/14 10:17, Dehao Chen wrote: >>> >>> We need to rebuild frequency after vrp, otherwise the following code >>> in tree-ssa-threadupdate.c will make the frequency larger than >>> upper-bound. >>> >>> /* Excessive jump threading may make frequencies large enough >>> so >>> the computation overflows. */ >>> if (rd->dup_blocks[0]->frequency < BB_FREQ_MAX * 2) >>> rd->dup_blocks[0]->frequency += EDGE_FREQUENCY (e); >>> >>> This is referring to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61384 >> >> Can you try this with Teresa's revamping of the jump threading frequency >> updates? It's still in my queue of things to review. >> >> Fixing this stuff in the updater would be better than rebuilding the >> frequencies, IMHO. >> >> Jeff >> -- Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413
