Looks good except for :

diff --git a/gcc/testsuite/lib/target-supports.exp
b/gcc/testsuite/lib/target-supports.exp
index ef370fe..7e1ec71 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -3280,7 +3280,8 @@ proc check_effective_target_vect_bswap { } {
>     verbose "check_effective_target_vect_bswap: using cached result" 2
>     } else {
>     set et_vect_bswap_saved 0
>-    if { [istarget aarch64*-*-*] } {
>+    if { [istarget aarch64*-*-*]
>+         || [istarget arm*-*-*] } {

This condition should have && [check_effective_target_arm_neon]  or
you'll break testing on AArch32 non-neon targets especially as this is
an implicit run time test.

Ok with that change.

Ramana

On Fri, May 16, 2014 at 3:45 PM, Kyrill Tkachov <kyrylo.tkac...@arm.com> wrote:
> Hi all,
>
> This is the aarch32 version of
> https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00850.html that allows us to
> (auto-)vectorise the __builtin_bswap[16,32,64] functions using the vrev
> instructions.
> For that we create some new NEON builtins and get
> arm_builtin_vectorized_function to map to them when asked to vectorise the
> corresponding builtin.
>
> The tests for this were added with the aarch64 patch mentioned above but
> were disabled for arm. This patch enables them now that we support the
> operations (of course they now pass on arm)
>
> Tested arm-none-eabi and bootstrapped on arm-none-linux-gnueabihf.
>
> Ok for trunk?
>
>
> Thanks,
> Kyrill
>
> 2014-05-16  Kyrylo Tkachov  <kyrylo.tkac...@arm.com>
>
>     * config/arm/neon.md (neon_bswap<mode>): New pattern.
>     * config/arm/arm.c (neon_itype): Add NEON_BSWAP.
>     (arm_init_neon_builtins): Handle NEON_BSWAP.
>     Define required type nodes.
>     (arm_expand_neon_builtin): Handle NEON_BSWAP.
>     (arm_builtin_vectorized_function): Handle BUILTIN_BSWAP builtins.
>     * config/arm/arm_neon_builtins.def (bswap): Define builtins.
>     * config/arm/iterators.md (VDQHSD): New mode iterator.
>
> 2014-05-16  Kyrylo Tkachov  <kyrylo.tkac...@arm.com>
>
>     * lib/target-supports.exp (check_effective_target_vect_bswap):
>     Specify arm*-*-* support.

Reply via email to