On Tue, May 13, 2014 at 9:27 PM, Florian Weimer <fwei...@redhat.com> wrote: > Patterns that trigger the optimization and warning can form after inlining, > and it can be rather difficult to figure out what exactly is causing the > warning. The inlining context at least provides additional hints, enabling > developers to substitute the arguments and discover what, precisely, is > happening. > > More context is provided with -g than without, but I think this is > acceptable. > > I bootstrapped and tested the attached patch on x86_64-redhat-linux-gnu, > with no new regressions.
I think that your block walking code is bogus in that it looks at only BLOCK_SOURCE_LOCATION, exposing an implementation detail that should be hidden by using inlined_function_outer_scope_p. It also will print an unlimited call stack - isn't that too verbose? Thanks, Richard. > -- > Florian Weimer / Red Hat Product Security Team
