On Wed, Apr 30, 2014 at 07:56:07AM +0200, Marc Glisse wrote: > Minor detail: > > + if ((flags & OPTION_MASK_FLOAT128) != 0) > + rs6000_define_or_undefine_macro (define_p, "__FLOAT128__"); > > I recently added __SIZEOF_FLOAT128__ to the x86 target to advertise > the availability of __float128, it would be good if we had a common > macro (it can be in addition to __FLOAT128__). If you really don't > like it, we can ask x86 maintainers if they like __FLOAT128__.
I would prefer to have common names between the x86 and PowerPC, since our two ports are the main two that had long double types that weren't either a straight IEEE 64-bit or IEEE 128-bit representation. I can certainly switch the PowerPC to use the same name as the x86. When I began the port, I didn't notice there was a define that said the __float128 type was available, so I just picked a name out of the air. I do think when we agree on a name, it would be helpful if quad.h in libgcc/soft-fp (which comes from the glibc sources) used that to use the __float128 type. Unfortunately, given the IBM double-double size is 128-bits, the attribute((mode(TF))) won't work for us. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.vnet.ibm.com, phone: +1 (978) 899-4797
