On Thu, Mar 27, 2014 at 04:32:19PM +0100, Andreas Krebbel wrote:
> On 27/03/14 15:15, Jakub Jelinek wrote:
> > Does this fix the:
> > -__fixdfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> > -__fixsfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> > -__fixtfti@@GCC_4.1.0 FUNC GLOBAL DEFAULT
> > -__fixunsdfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> > -__fixunssfti@@GCC_3.0 FUNC GLOBAL DEFAULT
> > -__fixunstfti@@GCC_4.1.0 FUNC GLOBAL DEFAULT
> > regression when comparing
> > readelf -Ws libgcc_s.so.1 | sed -n '/\.symtab/,$d;/ UND
> > /d;/@GLIBC_PRIVATE/d;/\(GLOBAL\|WEAK\|UNIQUE\)/p' | awk '{ if ($4 ==
> > "OBJECT") { printf "%s %s %s %s %s\n", $8, $4, $5, $6, $3 } else { printf
> > "%s %s %s %s\n", $8, $4, $5, $6 }}' | LC_ALL=C sort -u
> > output between 4.8 and 4.9?
> Yes. It does fix it.
Looks ok to me.
> >> #if defined(__x86_64__) || (!defined(__i386__) && defined(__LP64__)) \
> >> - || defined(__mips64)
> >> + || defined(__mips64) || defined(__s390x__)
> >> host_address=64
> >> #else
> >> host_address=32
> >
> > Why is this needed? Don't s390x define __LP64__ ?
>
> We do. I'll remove it.
BTW, your patch forced me to look at abilists of versioned shared libraries
between 4.8.x and trunk and these 6 symbols are the only ones that are
removed from {i?86,x86_64,ppc,ppc64,s390,s390x} arches.
Jakub
