Re: [gomp4 2/2] Initial support for the OpenACC kernels construct in the C front end.

[Thomas Schwinge]

Hi!

On Fri, 28 Feb 2014 10:23:01 +0100, I wrote:
> diff --git gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c 
> gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c
> index 24a4c11..d88ee8a 100644
> --- gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c
> +++ gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c

> +/* TODO: While the OpenACC specification does allow for certain kinds of
> +   nesting, we don't support that yet.  */
> +void
> +f_acc_kernels (void)
> +{
> +#pragma acc parallel
> +  {
> +#pragma acc parallel /* { dg-error "may not be nested" } */
> +    ;
> +#pragma acc kernels  /* { dg-error "may not be nested" } */
> +    ;
>  #pragma acc data     /* { dg-error "may not be nested" } */
>      ;
>    }

Applied in r208700 to gomp-4_0-branch:

commit 82e6bd6f0623d40a7653cf1ca61d14726cbe398f
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Mar 20 14:25:47 2014 +0000

    Fix test to actually test for nesting inside of OpenACC kernels construct.
    
        gcc/testsuite/
        * c-c++-common/goacc/nesting-fail-1.c (f_acc_kernels): Replace
        OpenACC parallel with kernels directive.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@208700 
138bc75d-0d04-0410-961f-82ee72b054a4

diff --git gcc/testsuite/ChangeLog.gomp gcc/testsuite/ChangeLog.gomp
index 81876ec..fd38d80 100644
--- gcc/testsuite/ChangeLog.gomp
+++ gcc/testsuite/ChangeLog.gomp
@@ -1,5 +1,8 @@
 2014-03-20  Thomas Schwinge  <tho...@codesourcery.com>
 
+       * c-c++-common/goacc/nesting-fail-1.c (f_acc_kernels): Replace
+       OpenACC parallel with kernels directive.
+
        * c-c++-common/goacc/parallel-1.c: Don't recurse.
 
        * gfortran.dg/goacc/cache-1.f95: Replace dg-excess-errors usage
diff --git gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c 
gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c
index d88ee8a..ca8921f 100644
--- gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c
+++ gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c
@@ -19,7 +19,7 @@ f_acc_parallel (void)
 void
 f_acc_kernels (void)
 {
-#pragma acc parallel
+#pragma acc kernels
   {
 #pragma acc parallel   /* { dg-error "may not be nested" } */
     ;


Grüße,
 Thomas

pgpwPI4VSO4jZ.pgp
Description: PGP signature