Hi Thomas!

On 13.03.2014 15:38, Thomas Schwinge wrote:
Hi Ilmir!

On Thu, 13 Mar 2014 13:34:54 +0400, Ilmir Usmanov <i.usma...@samsung.com> wrote:
Committed as r208533.
Yay!  \o/
Thanks! Yay indeed.

And thanks a lot for your comments.


The following change seems the right thing to do -- but why doesn't the
current code trigger a GCC ICE due to a failing subcode check?  (At least
I thought you had test cases exercising the respective OpenACC vector
clauses?)  Can you please check that?  If it's just missing a test case,
feel free to commit that together with my patch.

Unfortunally, I can't check this using a test right now, since OpenACC loop directive is not implemented yet.


The following cleanup should be fine to check in, or is there a reason
for using OMP_WAIT_EXPR instead of OMP_CLAUSE_WAIT_EXPR?
No, there is no reason for using OMP_WAIT_EXPR. Thanks!

--
Ilmir.


Reply via email to