On 03/12/2014 11:46 AM, Tobias Burnus wrote:
> Jerry DeLisle wrote:
>> + if (dtp->common.unit == 0)
>> + {
>> + len = string_len_trim (dtp->internal_unit_len,
>> + dtp->internal_unit);
>> + if (len > 0)
>> + dtp->internal_unit_len = len;
>> + iunit->recl = dtp->internal_unit_len;
>> + }
> Is there a reason for having the "len > 0" check? And would the following
> work?
>
> dtp->internal_unit_len = len ? len : 1;
>
>> + if (len > 0)
>> + dtp->internal_unit_len = len;
>
> Ditto.
>
> Otherwise, it looks good to me - even if Dominique has found another special
> case [PR38199, Comment 14], where the performance is with patch is 7% lower.
>
> Tobias
>
I cleaned it up a bit around that logic in unit.c, Added a snippit in
list_read.c to take care of comment #41 of the PR, regression tested, NIST
tested and committed.
Sending ChangeLog
Sending io/list_read.c
Sending io/read.c
Sending io/unit.c
Transmitting file data ....
Committed revision 208528.
Thanks for review.
I plan to continue some looking at the eat_line function which I think can be
done
more efficiently, but no hurry.
Jerry
