On Mon, Feb 24, 2014 at 11:08:27PM +0530, Prathamesh Kulkarni wrote:
> I apologize for bothering with stupid mistakes.

No problem, it takes some time to get up to speed.
 
> +  mark_exp_read (expr.value);
> +  if (TREE_CODE (expr.value) == COMPONENT_REF
> +      && DECL_C_BIT_FIELD (TREE_OPERAND (expr.value, 1)))
> +     error_at (expr_loc, "%<sizeof%> applied to a bit-field");
> +  return c_expr_sizeof_expr (expr_loc, expr);
>  }

This still doesn't seem quite right.  As I said:

> > And this should be
> >   if (TREE_CODE (expr.value) == COMPONENT_REF
> >       && DECL_C_BIT_FIELD (TREE_OPERAND (expr.value, 1)))
> >     error_at (expr_loc, "%<sizeof%> applied to a bit-field");
> >   return c_expr_sizeof_expr (expr_loc, expr);
> >

That is, no tab before error_at (...), but four spaces.
(Of course there's no need to retest the patch when making such
trivial adjustments.)

        Marek

Reply via email to