Hi Ilya! On Mon, 17 Feb 2014 21:06:41 +0400, Ilya Verbin <iver...@gmail.com> wrote: > Here is the fix for the issue discussed in > http://gcc.gnu.org/ml/gcc/2014-02/msg00257.html > > OK to commit to gomp-4_0-branch?
> + * target.c (gomp_map_vars_existing): Don't update copy_from for the > + existing mappings. > --- a/libgomp/target.c > +++ b/libgomp/target.c > @@ -171,11 +171,6 @@ gomp_map_vars_existing (splay_tree_key oldn, > splay_tree_key newn, > "[%p..%p) is already mapped", > (void *) newn->host_start, (void *) newn->host_end, > (void *) oldn->host_start, (void *) oldn->host_end); > - if (((kind & 7) == 2 || (kind & 7) == 3) > - && !oldn->copy_from > - && oldn->host_start == newn->host_start > - && oldn->host_end == newn->host_end) > - oldn->copy_from = true; > oldn->refcount++; > } Sure; this was the consensus, as I understand it. Though, wouldn't it make sense to also add a test case to a) test for this behavior, and also b) to document the "GCC interpretation of the OpenMP standard" in this case (including a link to the OpenMP issue tracker, or Jakub's email on this topic)? Grüße, Thomas
pgpkQQKsIlfYO.pgp
Description: PGP signature
