Hi Mike, > -----Original Message----- > From: Mike Stump [mailto:mikest...@comcast.net] > Sent: Friday, 14 February 2014 6:01 pm > To: David Holsgrove > Cc: gcc-patches@gcc.gnu.org; Michael Eager (ea...@eagerm.com); Vidhumouli > Hunsigida; Nagaraju Mekala; John Williams; Edgar Iglesias > Subject: Re: [Patch, testsuite]: Allow MicroBlaze .weakext pattern in regex > match > > On Feb 13, 2014, at 10:07 PM, David Holsgrove <david.holsgr...@xilinx.com> > wrote: > > I've attached a patch to extend the regex pattern to include optional 'ext' > > at the > end of > > '.weak' to match the MicroBlaze weak label '.weakext' in two of the g++ test > cases. > > I don’t feel strongly either way. I'd like think weak(_definition)?(ext)?….. > is good > enough, as this test doesn’t much care beyond that. > > spec34 does: > > { dg-final { scan-assembler ".weak(_definition)?\[\t \]*_?_Z2f2IiEvT_” > > for example. Which I think is fairly readable/maintainable. > > Let’s give others that might disagree with me an opportunity to do so… I’m > happy to defer to anyone that has a stronger opinion than mine. If no one > steps > forward, I’ll ok either way you want to go. > > Wearing my hat as darwin/testsuite maintainer. :-)
Thanks for the reply, I'd be happy with reducing the number of matches in those
tests to use optional 'ext' or optional '_definition' as you suggested.
I've attached an updated patch to consolidate and remove the separate Darwin
tests, so we can go with either approach if anyone else has an opinion.
ChangeLog/testsuite
2014-02-14 David Holsgrove <david.holsgr...@xilinx.com>
* gcc/testsuite/g++.dg/abi/rtti3.C: Extend scan-assembler
pattern to take optional patterns and remove darwin test.
* gcc/testsuite/g++.dg/abi/thunk3.C: Likewise.
* gcc/testsuite/g++.dg/abi/thunk4.C: Likewise.
thanks,
David
0005-Patch-testsuite-Extend-.weak-pattern-in-regex-match.patch
Description: 0005-Patch-testsuite-Extend-.weak-pattern-in-regex-match.patch
