Hi Michael, List,

> -----Original Message-----
> From: David Holsgrove
> Sent: Wednesday, 22 January 2014 1:43 pm
> To: 'Michael Eager'; gcc-patches@gcc.gnu.org
> Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala
> Subject: RE: [Patch, microblaze]: Remove SECONDARY_MEMORY_NEEDED
> 
> Hi Michael,
> 
> > -----Original Message-----
> > From: Michael Eager [mailto:ea...@eagerm.com]
> > Sent: Friday, 17 January 2014 4:44 am
> > To: David Holsgrove; gcc-patches@gcc.gnu.org
> > Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala
> > Subject: Re: [Patch, microblaze]: Remove SECONDARY_MEMORY_NEEDED
> >
> > On 11/25/13 23:51, David Holsgrove wrote:
> > > Hi Michael,
> > >
> > > I've attached patch based on latest gcc master. Please let me know if
> > > you need anything further.
> > >
> > > thanks,
> > > David
> > >
> > > On 15 July 2013 14:44, David Holsgrove <david.holsgr...@xilinx.com> wrote:
> > >> Hi Michael,
> > >>
> > >> On 18 March 2013 22:49, David Holsgrove <david.holsgr...@xilinx.com>
> > wrote:
> > >>> MicroBlaze doesn't have restrictions that would force us to
> > >>> reload regs via memory. Don't define SECONDARY_MEMORY_NEEDED.
> > >>> Fixes an ICE when compiling OpenSSL for linux.
> > >>>
> > >>> Changelog
> > >>>
> > >>> 2013-03-18  Edgar E. Iglesias <edgar.igles...@xilinx.com>
> > >>>
> > >>>   * gcc/config/microblaze/microblaze.h: Remove
> > SECONDARY_MEMORY_NEEDED
> > >>>     definition.
> > >>>
> > >>> Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com>
> > >>> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwa...@xilinx.com>
> > >>>
> > >>
> > >> Patch remains the same, please apply when ready.
> > >>
> > >> thanks,
> > >> David
> >
> > Hi David --
> >
> > Is it possible to add a test case which shows the ICE?
> >
> 
> I'm afraid I don’t still have my test environment for this patch from last 
> March, I'll
> attempt to recreate and distil into a small test case if possible, based on 
> the error
> encountered whilst building openssl.
> 
> I'll update again when I have some further detail.
> 

I've managed to recreate the original internal compiler error whilst building 
openssl with microblazeel linux toolchain.

I've reduced the error down to the attached testcase.
It is taken directly from openssl (with no dependencies on openssl headers), so 
I'm unsure of the suitability of this test both technically and license wise 
for inclusion in gcc.

Changelog entry would be;

2013-03-18  Edgar E. Iglesias <edgar.igles...@xilinx.com>

 * gcc/config/microblaze/microblaze.h: Remove SECONDARY_MEMORY_NEEDED
   definition.

ChangeLog/testsuite

2014-02-13  David Holsgrove <david.holsgr...@xilinx.com>

 * gcc/testsuite/gcc.target/microblaze/others/mem_reload.c: New test.

thanks,
David


> thanks,
> David
> 
> > Thanks.
> >
> >
> > --
> > Michael Eager        ea...@eagercon.com
> > 1960 Park Blvd., Palo Alto, CA 94306  650-325-8077



Attachment: 0002-Patch-microblaze-Remove-SECONDARY_MEMORY_NEEDED.patch
Description: 0002-Patch-microblaze-Remove-SECONDARY_MEMORY_NEEDED.patch

Reply via email to