> gen_subprogram_die is often called more than once for the same decl > (e.g. the first time through force_decl_die etc.), but it always > unconditionally calls add_calling_convention_attribute which thus > may add the attributes several times. > > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk?
Looks good to me. > Alternatively, we could avoid the add_calling_convention_attribute > call in gen_subprogram_die if subr_die == orig_die, i.e. if we have > already processed the decl once, hopefully the calling conventions would be > the same in all cases. s/orig_die/old_die/ This sounds a little more efficient -- no calls to get_AT just to see if the attribute has already been added. I've got a slight preference for your alternate proposal (assuming it works). -cary
