On 09/12/13 13:07, Maxim Kuvyrkov wrote: > On 9/12/2013, at 8:21 am, Maxim Kuvyrkov <ma...@kugelworks.com> wrote: > >> On 9/12/2013, at 3:24 am, Jan-Benedict Glaw <jbg...@lug-owl.de> wrote: >> >>> Hi Maxim! >>> >>> One of your recent libc<->android clean-up patches broke the >>> mips64-linux target as a side-effect, see eg. >>> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=53806: >>> >>> g++ -c -DIN_GCC_FRONTEND -DIN_GCC_FRONTEND -g -O2 -DIN_GCC >>> -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti >>> -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings >>> -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long >>> -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H >>> -I. -Ic-family -I/home/jbglaw/repos/gcc/gcc >>> -I/home/jbglaw/repos/gcc/gcc/c-family >>> -I/home/jbglaw/repos/gcc/gcc/../include >>> -I/home/jbglaw/repos/gcc/gcc/../libcpp/include >>> -I/home/jbglaw/repos/gcc/gcc/../libdecnumber >>> -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber >>> -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o c-family/c-cppbuiltin.o >>> -MT c-family/c-cppbuiltin.o -MMD -MP -MF c-family/.deps/c-cppbuiltin.TPo >>> /home/jbglaw/repos/gcc/gcc/c-family/c-cppbuiltin.c >>> /home/jbglaw/repos/gcc/gcc/c-family/c-cppbuiltin.c: In function ‘void >>> c_cpp_builtins(cpp_reader*)’: >>> /home/jbglaw/repos/gcc/gcc/c-family/c-cppbuiltin.c:1014:370: error: >>> ‘ANDROID_TARGET_OS_CPP_BUILTINS’ was not declared in this scope >>> make[1]: *** [c-family/c-cppbuiltin.o] Error 1 >> >> I'm looking into this. > > My recent patches to cleanup support for Android/Bionic for *-linux-* targets > broke mips64-linux and s390x-linux builds. Unfortunately, these targets fell > out from the test coverage of these cleanups. > > The problems are in missing declarations, and are trivial to fix by adding > necessary files in config.gcc. > > The fix for mips64-linux (and, also, mips*-mti-linux*) is to add > linux-android.h and linux-android.opt to the target header/option files -- > thus enabling android handling for all mips*-linux* toolchains. > > The fix for s390x-linux is to add linux-protos.h to target headers. No > android handling is added to s390x-linux. > > Richard, Andreas, are you OK with changes to your respective ports? Patch is ok. It fixes bootstrap failure about missing linux_has_ifunc_p.
Thanks! -Andreas-
