Oleg Endo <oleg.e...@t-online.de> wrote: >On Fri, 2013-12-06 at 16:57 +0100, Steven Bosscher wrote: >> On Fri, Dec 6, 2013 at 3:51 PM, David Malcolm wrote: >> > * asan.c (transform_statements): Eliminate use of >last_basic_block >> > in favor of last_basic_block_for_fn, in order to make use >of cfun >> > explicit. >> >> Can we please make all this _for_fn go away? >> > >Sorry if this has been discussed before... but why not adding member >functions to 'function' instead of freestanding macros/functions that >take a function* as a first argument? This would also make it easier >to >eliminate the "_for_fn" (freestanding function/macro name clashes etc) >I >think.
Both can be done, but these patches make cfun uses explicit which was the goal while following existing practice. Richard. >Cheers, >Oleg