On Fri, Nov 29, 2013 at 02:58:47PM +0400, Yury Gribov wrote:
> --- a/gcc/testsuite/lib/asan-dg.exp
> +++ b/gcc/testsuite/lib/asan-dg.exp
> @@ -39,9 +39,9 @@ proc asan_link_flags { paths } {
> set shlib_ext [get_shlib_extension]
>
> if { $gccpath != "" } {
> + append flags " -B${gccpath}/libsanitizer/asan/ "
> if { [file exists "${gccpath}/libsanitizer/asan/.libs/libasan.a"]
> || [file exists
> "${gccpath}/libsanitizer/asan/.libs/libasan.${shlib_ext}"] } {
> - append flags " -B${gccpath}/libsanitizer/asan/ "
Please fix up formatting, if you move append flags outside of the
conditional, it needs to be indented the same as the if below it.
> append flags " -L${gccpath}/libsanitizer/asan/.libs "
> append ld_library_path ":${gccpath}/libsanitizer/asan/.libs"
> }
> diff --git a/gcc/testsuite/lib/ubsan-dg.exp b/gcc/testsuite/lib/ubsan-dg.exp
> index 4ec5fdf..b7f2b17 100644
> --- a/gcc/testsuite/lib/ubsan-dg.exp
> +++ b/gcc/testsuite/lib/ubsan-dg.exp
> @@ -30,9 +30,9 @@ proc ubsan_link_flags { paths } {
> set shlib_ext [get_shlib_extension]
>
> if { $gccpath != "" } {
> + append flags " -B${gccpath}/libsanitizer/ubsan/ "
> if { [file exists "${gccpath}/libsanitizer/ubsan/.libs/libubsan.a"]
> || [file exists
> "${gccpath}/libsanitizer/ubsan/.libs/libubsan.${shlib_ext}"] } {
> - append flags " -B${gccpath}/libsanitizer/ubsan/ "
Likewise.
Also, isn't libsanitizer/libsanitizer.spec.in missing from the patch?
Ok with that fixed.
Jakub
