On Thu, Nov 21, 2013 at 12:19 AM, Zdenek Dvorak <rakd...@iuuk.mff.cuni.cz> wrote: > Hi, > >> This patch works on the intrinsic calls handling issue in IVOPT mentioned >> here: >> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01295.html >> >> In find_interesting_uses_stmt, it changes >> >> arg = expr >> __builtin_xxx (arg) >> >> to >> >> arg = expr; >> tmp = addr_expr (mem_ref(arg)); >> __builtin_xxx (tmp, ...) > > this looks a bit confusing (and wasteful) to me. It would make more sense to > just record the argument as USE_ADDRESS and do the rewriting in > rewrite_use_address. > > Zdenek
My intention was to use find_interesting_uses_address directly. But you are right, the logic looks better to only do the rewriting in rewrite_use_address. I will change here. Thanks, Wei.