On Wed, Nov 20, 2013 at 4:06 PM, Trevor Saunders <tsaund...@mozilla.com> wrote: > On Wed, Nov 20, 2013 at 03:18:07PM +0100, Richard Biener wrote: >> On Wed, Nov 20, 2013 at 3:16 PM, Jakub Jelinek <ja...@redhat.com> wrote: >> > On Wed, Nov 20, 2013 at 03:12:34PM +0100, Richard Biener wrote: >> >> The limit looks reasonable, but you could have used a simple linked >> >> list (and never free). Also being able to pop a random context >> >> looks fragile ... that is, pop_gimplify_context shouldn't have an >> >> argument. >> > >> > Can't we use stack_vec<gimplify_context, 30> for that? Though that would >> > mean a global var constructor and destructor, so alternatively just use >> > a normal vec and .create(30) it somewhere during initialization? >> >> only with gimplify_context *, otherwise things will break during >> re-allocation. > > hm? it seems like the only member of gimplify_ctx that can't just be > memcpyd is the prev pointer which presumably could go away if you have a > vec of all the contexts.
Callers have a pointer to gimplify_context AFAIK. Richard. > Trev > >> >> Richard. >> >> > Jakub
