On Tue, Nov 19, 2013 at 1:59 AM, Alan Modra <amo...@gmail.com> wrote:
> This patch disables the default -mstrict-align on power8. Rather than > testing values from enum processor_type, which is prone to error when > adding a new processor, I chose one of the mask bits that happens to > be set for power8, and is likely to be set for future new processors. > I also take the opportunity to update PROCESSOR_DEFAULT64 to the value > most likely appropriate for machines running ELFv2. Bootstrapped and > regression tested powerpc64-linux. OK to apply? > > David, it also occurs to me that PROCESSOR_DEFAULT* isn't the best > choice of macro name nowadays. The macro is only used to default > -mtune, not -mcpu. If you think it a good idea, I'll > s/PROCESSOR_DEFAULT/TUNE_DEFAULT/ throughout config/rs6000 as a > followup commit to this one. > > * config/rs6000/sysv4.h (CC1_ENDIAN_LITTLE_SPEC): Define as empty. > * config/rs6000/rs6000.c (rs6000_option_override_internal): Default > to strict alignment on older processors when little-endian. > * config/rs6000/linux64.h (PROCESSOR_DEFAULT64): Default to power8 > for ELFv2. The patch is okay. I agree that the mechanism for selecting the default tuning should be cleaned up, but renaming PROCESSOR_DEFAULT to TUNE_DEFAULT just papers over the issue. Thanks, David
