On Mon, 2013-11-18 at 10:05 +0100, Andreas Krebbel wrote: > With the patch the htm-nofloat-2 testcase fails. Due to the > "returns_twice" flag on tbegin the optimizers fail to fold the > compares of the condition code and the s390_optimize_nonescaping_tx > routine in turn fails to optimize the simple transactions. This will > hopefully be fixed with a follow-on patch.
Hi Andreas, I assume you're using the returns_twice attribute on your tbegin builtin so that the compiler will help you with the handling of the floating point registers since they are not restored on the s390's transaction failure? We don't have that attribute set on POWER's tbegin builtin and I don't think we should since all of our registers are restored on a transaction failure, but I'd like to know if you added that attribute for any other reason such that POWER should have it too? Peter