On Tue, Nov 12, 2013 at 08:30:15PM +0100, Jakub Jelinek wrote:
> Anyway, the following #ifdefs out tons of dead code and still builds just
> fine, the only difference is that those symbols nothing really uses from
> libasan/libtsan are no longer exported, but nothing else changes.
Actually, ifdefing out the *limits_posix.cc file didn't work well, because
the ioctl wrapping isn't dead, so I'm afraid we are back to including
sys/vt.h again. But, at least for now the dead syscall interception
is #ifdefed out. Tested on x86_64-linux, committed to trunk.
> I guess the #if 0 can be replaced by some #ifdef with some nice name or
> something.
>
> BTW, the 10MB .bss in libubsan is really insane, while perhaps users are
> expecting to have huge overhead with libasan or libtsan, for libubsan it
> looks way too big. Why do you need it?
Seems the allocator is brought in through a chain of *.o files from
sanitizer_common, libubsan wants the backtrace stuff, but I'd hope if it
needs an allocator for that, it doesn't need one backed by 10MB .bss buffer,
some fairly minimal would be much better for that.
Jakub
