> 1) I don't think you need in_mem flag. For in memory merge, the source != > NULL.
discard this comment. David > > > > > > > On Thu, Nov 7, 2013 at 3:34 PM, Rong Xu <x...@google.com> wrote: >> On Thu, Nov 7, 2013 at 9:40 AM, Joseph S. Myers <jos...@codesourcery.com> >> wrote: >>> On Thu, 7 Nov 2013, Rong Xu wrote: >>> >>>> Thanks Joseph for these detailed comments/suggestions. >>>> The fixed patch is attached to this email. >>>> The only thing left out is the Texinfo manual. Do you mean this tool >>>> should have its it's own texi file in gcc/doc? >>> >>> Its own texi file, probably included as a chapter by gcc.texi (like >>> gcov.texi is). >> >> OK. will add this in. >> >> My last patch that changes the command handling is actually broken. >> Please ignore that patch and use the one in this email. >> >> Also did some minor adjust of the code in libgcov. >> >> Thanks, >> >> -Rong >> >> >>> >>> -- >>> Joseph S. Myers >>> jos...@codesourcery.com
