On 14/10/13 11:23, Paulo Matos wrote:
-----Original Message-----
From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On
Behalf Of Paulo Matos
Sent: 14 October 2013 11:22
To: Kyrill Tkachov
Cc: gcc-patches@gcc.gnu.org
Subject: RE: [PATCH] Fix PR58682
OK, testcase generated. Patch attached but there are a few issues and need
some comments.
I am sorry, I forgot to attach the patch. Here it is.
OK, testcase generated. Patch attached but there are a few issues and need some
comments.
* The test includes 6 additional sources and 3 headers. This feels like it
pollutes the test
directory a lot. Should I at least submit preprocessed sources, so that the
headers disappear?
* The sources come from CoreMark, does anybody know if their license allows
us to include this
test in GCC? Also, the code if formatted with CoreMark formatting, should I
just use indent to
properly format the patch?
I'd think there would be legal issues adding coremark to the testsuite but I'm
not an expert on this. In any case, I think it's too big of a testcase. Any way
we could reduce it?
* Last, but not least, this patch only causes an ICE on 4_8, but not because
trunk is fixed.
Instead trunk generates edge counts in such a way that they never happen to be
higher than max_count
when a call is inlined. Is it still worth it to get it into trunk (even though
trunk should
still be patched?)
CC'ing one of the testsuite maintainers...
Kyrill
