On Wed, Sep 11, 2013 at 11:22 AM, Caroline Tice <cmt...@google.com> wrote:
> This patch should fix the issues that people were having with the
> libvtv testsuite being run (and failing) when GCC was not configured
> with --enable-vtable-verify. I am still in the process of running
> some tests, but at this point I am fairly confident that this patch
> works correctly. Even though I am the libvtv maintainer, I would
> appreciate someone else reviewing this patch too, as a sanity check.
>
> -- Caroline Tice
> cmt...@google.com
>
> 2013-09-11 Caroline Tice <cmt...@google.com>
>
> * Makefile.am: Re-instante ENABLE_VTABLE_VERIFY checks, to make
> sure testsuite is not run if libstdc++ and libgcc were not built
> with vtable verification.
> * Makefile.in: Regenerated.
> * configure.ac: Re-instatate checks for --enable-vtable-verify flag,
> to make sure testsuite is not run if libstdc++ and libgcc were not
> built with vtable verification.
> * configure: Regenerated.
I tried it. I noticed 2 issues:
1. Correct if I am wrong. libvtv doesn't work correctly if
--enable-vtable-verify
isn't used. Why is libvtv built/installed at all when
--enable-vtable-verify isn't used.
2. Why does libvtv/configure.ac have
echo 'MULTISUBDIR =' >> $ac_file
ml_norecursion=yes
. ${multi_basedir}/config-ml.in
when AM_ENABLE_MULTILIB is used? I got
make[3]: Entering directory
`/export/build/gnu/gcc/build-x86_64-linux/x86_64-unknown-linux-gnu/libvtv'
Makefile:844: warning: overriding recipe for target `multi-do'
Makefile:775: warning: ignoring old recipe for target `multi-do'
Makefile:892: warning: overriding recipe for target `multi-clean'
Makefile:823: warning: ignoring old recipe for target `multi-clean'
--
H.J.
