On Thu, Sep 5, 2013 at 5:02 PM, Mike Stump <mikest...@comcast.net> wrote: > On Sep 5, 2013, at 7:42 AM, Joern Rennecke <joern.renne...@embecosm.com> > wrote: >> This patch has not been reviewed for more than two weeks: >> http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00990.html > > I'd like a pta type person (or anyone that has an opinion on the change) to > review/comment on this… Surely we have at least 1 person that still works in > that area around here… > > This is the type of change: > > Index: gcc.dg/tree-ssa/pta-escape-2.c > =================================================================== > --- gcc.dg/tree-ssa/pta-escape-2.c (revision 201835) > +++ gcc.dg/tree-ssa/pta-escape-2.c (working copy) > @@ -34,5 +34,5 @@ int main() > return 0; > } > > -/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" } } */ > +/* { dg-final { scan-tree-dump "ESCAPED = { NULL ESCAPED NONLOCAL x }" > "alias" { target { ! keeps_null_pointer_checks } } } } */ > /* { dg-final { cleanup-tree-dump "alias" } } */ > > if you are not sure you want to click on the link.
I'd say rather than just disabling the scan for keeps_null_pointer_checks you should add appropriate scanning for those targets as well (I expect you just don't see the 'NULL's in the points-to sets). Richard.
