Hi Jakub,
thanks for your review. I also answered Maxim in the initial thread.
I agree we your points about not enforcing Android stuff into all
*linux* targets, but for e.g
tm_file="$tm_file linux-android.h"
.. this enforcing been there before my patch and therefore it would be
better to address this in the follow-up patch (I can work on that).
and btw we define all supported by linux libcs (LIBC_GLIBC,
LIBC_BIONIC, LIBC_UCLIBC) in linux.opts and we also add it to all
*linux* targets
thanks,
Alexander
2013/9/3 Jakub Jelinek <ja...@redhat.com>:
> On Tue, Sep 03, 2013 at 09:25:31AM +0400, Alexander Ivchenko wrote:
>> Several builds are broken after r201838.
>
> What targets actually support bionic? If it is just arm, i?86/x86_64
> and perhaps aarch64 and nothing else, I'd like to question the way where
> you enforce all the
> # Add Android userspace support to Linux targets.
> case $target in
> *linux*)
> tm_p_file="${tm_p_file} linux-protos.h"
> tmake_file="${tmake_file} t-linux-android"
> tm_file="$tm_file linux-android.h"
> extra_options="$extra_options linux-android.opt"
> extra_objs="$extra_objs linux-android.o"
> ;;
> esac
> stuff onto all Linux targets, without actually testing all of them.
> Wouldn't it be much better not to support Android in any way
> in config/linux.h (say at most #define TARGET_HAS_BIONIC 0 there,
> #ifdef HAVE_GNU_INDIRECT_FUNCTION
> #define TARGET_LIBC_HAS_FUNCTION hook_bool*true
> #endif
> etc.), and append the android stuff only to targets which you
> support, not before the target specific snippets in config.gcc,
> but after those (so linux-android.h, etc. come last, not first)?
>
> Jakub
