On Thu, Aug 22, 2013 at 06:09:40PM -0700, Ian Lance Taylor wrote: > On Thu, Aug 22, 2013 at 5:35 PM, Alan Modra <amo...@gmail.com> wrote: > > On Fri, Aug 16, 2013 at 06:18:05PM +0930, Alan Modra wrote: > >> I'd like to apply the following patch to the gcc repository (well, > >> excluding the libgo part which I'm hoping someone will apply for me to > >> the master go repository). I know the normal procedure for autotools > >> is to submit upstream then update when the patch is in the upstream > >> autotools repository, but this simple libtool patch has been awaiting > >> review for over two months. > > > > The libtool.m4 patch has finally been reviewed and accepted upstream. > > > > I'd like to import upstream libtool into gcc to support powerpc64le, > > and please, can someone do the same for upstream libgo? The reason we > > need this patch is that on a powerpc64le linux host where the compiler > > defaulted to producing 64-bit objects (which is how we generally build > > compilers nowadays) libtool added -m elf64ppc to $LD. Being the > > option for 64-bit big-endian, that caused complete failure for > > 64-bit little-endian. > > I've updated libgo/config/libtool.m4 and libgo/configure on mainline.
Thanks Ian, and I'm glad to see you patched libtool.m4 rather than importing upstream. Testing showed that importing libtool.m4 from upstream isn't such a great idea. For starters, we need to also import a new ltmain.sh, and then I ran into build problems in libsanitizer. libtool: compile: unable to infer tagged configuration libtool: error: specify a tag with '--tag' make[4]: *** [tsan_rtl_amd64.lo] Error 1 After rather a lot of time digging into libtool, I think this is due to a bad IFS init. The function that emits the error, func_infer_tag tries to see whether libtool is using $CC and fails because $CC has trailing spaces and a calculated $CC_expanded has tabs between the words of $CC. -- Alan Modra Australia Development Lab, IBM
