> Is this version ok for trunk? It looks resonable, but I still do not like much the removal of const for tables. Doing so will push them all into David Malcom's per-thread global universe.
Currently the algorithm is selected based on cost->memset/cost->memcpy. Instead of removing the const of all the CPU tables, I would preffer introducing two readwrite global variables memset_algs/memcpy_algs and feed them with proper table at a time we set up ix86_tune_features. This has chance to do the right thing with optimize attribute specifying algorithms and with the longer term threading plan. Honza > > thanks, > > David > > On Thu, Aug 8, 2013 at 9:31 AM, Xinliang David Li <davi...@google.com> wrote: > > Updated. > > > > thanks, > > > > David > > > > On Thu, Aug 8, 2013 at 8:18 AM, Joseph S. Myers <jos...@codesourcery.com> > > wrote: > >> On Wed, 7 Aug 2013, Xinliang David Li wrote: > >> > >>> Updated patch attached (fixed header, buffer overflow, and warning --> > >>> error problems). > >> > >> You still have diagnostics starting with a capital letter, contrary to the > >> GNU Coding Standards. > >> > >> -- > >> Joseph S. Myers > >> jos...@codesourcery.com
