> Hi, > > On Thu, Aug 01, 2013 at 03:11:36PM +0200, Jan Hubicka wrote: > > Hi, > > this is preparation work to move DECL_ARGUMENTS and DECL_RESULT into > > function > > sections during WPA. Even with some work to release unused ones, there are > > 4M > > of PARM_DECLs and 2M of RESULT_DECLs streamed during LTO (for 6M of > > function_decls) making them one of the most common nodes. > > > > This patch makes ipa-cp and ipa-prop to not use DECL_ARGUMENTS during WPA > > stage. this only needed to tamn debug info, move logic doing casts from > > get_replacement_map to tree_function_versioning and stream move_cost that is > > computed form parm type. > > > > Martin, does this patch look OK? > > > > Generally yes, except that I think you did not convert some dumping in > ipa-cp.c, at least in functions estimate_local_effects, > find_more_scalar_values_for_callers_subset and decide_about_value. I > believe that after your change there should not be a single call to > ipa_get_param in file ipa-cp.c.
Hmm, I was aware of that while making the patch but then forgot. OK, I will convert these too (and the testsuite) and commit. (alternative I was thining of having ipa_dump_param helper that will dump "parm 4" in WPA mode and "parm 4 (parmname)" in non-WPA). Do you think it would be useful? We probably should comonnize syntax of dumps in between ipa-prop and ipa-inline-analysis predicates (that currently use op4 syntax and call the parameters operands). Something to track incrementally anyway. Honza > > Thanks, > > Martin
