On Mon, Jul 22, 2013 at 9:12 AM, Paolo Carlini <paolo.carl...@oracle.com> wrote: > Also you are wrongly "un-uglyfying" many names, eg: > > - position_iterator __position; > - const value_type* __result; > - value_type __suffix; > - std::size_t __n; > - std::vector<int> __subs; > > > Remember all the names must begin by double underscore or single underscore, > etc.
Actually, in code before this patch, private members in class regex_iterator are indeed start without double or single underscore. It's because the standard (28.12, n3376) specifies them, though they are private. IMHO, they are part of standard, so I use names in it. Should I change them all to "_M_" or "__" format, and why? Thanks! -- Tim Shen
