On 07/09/2013 09:09 AM, Aldy Hernandez wrote:
+   is the controlling variable.  COND is the condition.  INCRP is a
+   pointer the increment expression (in case, the increment needs to

"pointer to"
No comma after "in case"

+      error_at (loc, "initialization variable must be of integral "
+               "or pointer type");

"induction variable", right?

This should print the declared type that isn't integral or pointer.

+      init = build_modify_expr (loc, decl, NULL_TREE, NOP_EXPR, rhs_loc,
+                               init, NULL_TREE);

Use INIT_EXPR for initialization.

I think you need to clear DECL_INITIAL.

+    init = build2 (MODIFY_EXPR, void_type_node, decl, init);

INIT_EXPR again.

+                       "multiple clause defined here");

Maybe "other clause"?

+cpp_validate_cilk_plus_loop_aux (tree *tp, int *walk_subtrees, void *data)

Can you reorganize things so that this calls c_validate_cilk_plus_loop so we don't need to walk the trees an extra time for C++?

+                   "continue statement within <#pragma simd> loop loop");

"loop body"?

+      error_at (loc, "expected iteration declaration");

"induction variable"?

+cp_parser_simd_for_init_statement (cp_parser *parser, tree *init,

This seems to be largely copied from cp_parser_omp_for_loop. They need to share code instead.

Jason

Reply via email to