On 18 June 2013 17:41, Ramana Radhakrishnan <[email protected]> wrote:
> On 06/18/13 09:50, Zhenqiang Chen wrote:
>>
>> Hi,
>>
>> During expand, function vcond<mode><mode> inverses some CMP, e.g.
>>
>> a LE b -> b GE a
>>
>> But if "b" is "CONST0_RTX", "b GE a" will be an illegal insn.
>>
>> (insn 933 932 934 113 (set (reg:V4SI 1027)
>> (unspec:V4SI [
>> (const_vector:V4SI [
>> (const_int 0 [0])
>> (const_int 0 [0])
>> (const_int 0 [0])
>> (const_int 0 [0])
>> ])
>> (reg:V4SI 1023 [ vect_var_.49 ])
>> (const_int 1 [0x1])
>> ] UNSPEC_VCGE)) PUGHSlab/Mapping.c:567 -1
>> (nil))
>>
>> Refer https://bugs.launchpad.net/linaro-toolchain-binaries/+bug/1189445
>> for more. And the bug also happens for FSF trunk.
>>
>> The similar issue
>> (https://bugs.launchpad.net/linaro-toolchain-binaries/+bug/1163942)
>> had fixed on AARCH64:
>> http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00581.html
>>
>> The patch is similar to the fix for aarch64.
>>
>> Bootstrap and no make check regression on Panda Board.
>>
>> Is it OK for trunk and 4.8?
>
>
> No, not without an appropriate set of testcases that exercise these cases.
Thanks for the comments. Patch is updated with a test case.
diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md
index 2761adb..6d9f604 100644
--- a/gcc/config/arm/neon.md
+++ b/gcc/config/arm/neon.md
@@ -1710,6 +1710,9 @@
case LE:
case UNLE:
inverse = 1;
+ /* Can not inverse "a LE 0" to "0 GE a". */
+ if (operands[5] == CONST0_RTX (<MODE>mode))
+ inverse = 0;
/* Fall through. */
case GT:
case UNGT:
diff --git a/gcc/testsuite/gcc.target/arm/lp1189445.c
b/gcc/testsuite/gcc.target/arm/lp1189445.c
new file mode 100644
index 0000000..8ce4b97
--- /dev/null
+++ b/gcc/testsuite/gcc.target/arm/lp1189445.c
@@ -0,0 +1,16 @@
+/* { dg-do compile } */
+/* { dg-options "-O3 -mfpu=neon -mcpu=cortex-a9 -mthumb
-mfloat-abi=hard -S" } */
+
+int id;
+int
+test (const long int *data)
+{
+ int i, retval;
+ retval = id;
+ for (i = 0; i < id; i++)
+ {
+ retval &= (data[i] <= 0);
+ }
+
+ return (retval);
+}
