It's fine with me. Please commit it directly to GCC and I'll put it in the upstream.
Thanks! AG ----- Original Message ----- From: "David Edelsohn" <dje....@gmail.com> To: "GCC Patches" <gcc-patches@gcc.gnu.org>, libffi-disc...@sourceware.org, "Alan Modra" <amo...@gmail.com> Sent: Sunday, June 23, 2013 10:32:44 PM Subject: Re: [RS6000] libffi little-endian On Sun, Jun 23, 2013 at 8:26 PM, Alan Modra <amo...@gmail.com> wrote: > On Fri, Jun 07, 2013 at 12:12:17AM -0400, David Edelsohn wrote: >> On Thu, Jun 6, 2013 at 9:34 PM, Alan Modra <amo...@gmail.com> wrote: >> > Bootstrapped and regression tested powerpc64-linux. OK to apply? >> > >> > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Support >> > little-endian. >> > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise. >> >> This patch needs to be applied upstream in the libffi repository. >> >> All of the handling of structs in ffi.c and ffi_darwin.c doesn't need >> any changes? Cool. I thought there might be a padding issue. > > You were right, of course. When we finally got around to running an > all languages bootstrap on powerpc64le, we discovered some missing > pieces in libffi. The following adds some ffi.c changes to the > previous patch (closure.S patches are unchanged). I haven't tackled > ffi_darwin.c. > > Bootstrapped and regression tested powerpc64-linux. This one passes > the libffi testsuite on powerpc64le-linux. OK mainline and 4.8? > > * src/powerpc/ffi.c (ffi_prep_args_SYSV): Move var declaration > before statements. > (ffi_prep_args64): Support little-endian. > (ffi_closure_helper_SYSV, ffi_closure_helper_LINUX64): Likewise. > * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Likewise. > * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Likewise. This looks okay to me and more like the changes I expected. Assuming Anthony accepts it upstream. Thanks, David
