On 06/17/2013 10:13 AM, Aldy Hernandez wrote:
> - data.simduid = tree_low_cst (gimple_call_arg (stmt, 0), 1);
> + data.simduid = gimple_call_arg (stmt, 0);
Doesn't this copy the ADDR_EXPR from the call into simduid?
> simduid_to_vf::hash (const value_type *p)
> {
> - return p->simduid;
> + return htab_hash_pointer (p->simduid);
... at which point this bit is meaningless since all ADDR_EXPRs must of course
have different pointers.
I think we should validate the DECL_P extracted from the call_arg, and store
that. The hash should use DECL_UID to minimize hash variation due to memory
layout.
r~
