RE: [PATCH] Handle MIPS EVA

[Moore, Catherine]

> -----Original Message-----
> From: Richard Sandiford [mailto:rdsandif...@googlemail.com]
> Sent: Monday, June 03, 2013 2:28 PM
> To: Moore, Catherine
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] Handle MIPS EVA
> 
> "Moore, Catherine" <catherine_mo...@mentor.com> writes:
> > Index: config/mips/mips.opt
> >
> ==========================================================
> =========
> > --- config/mips/mips.opt    (revision 199610)
> > +++ config/mips/mips.opt    (working copy)
> > @@ -141,6 +141,10 @@ membedded-data
> >  Target Report Var(TARGET_EMBEDDED_DATA)  Use ROM instead of RAM
> >
> > +meva
> > +Target Report Var(TARGET_EVA)
> > +Use microMIPS32/MIPS32 Enhanced VA instructions
> 
> This is likely to get out of date if EVA is ever extended to MIPS64.
> It's probably easier just to drop the "microMIPS32/MIPS32" bit.

Now done, plus incorporated Maciej's suggestion.

> 
> > Index: config/mips/mips.h
> >
> ==========================================================
> =========
> > --- config/mips/mips.h      (revision 199610)
> > +++ config/mips/mips.h      (working copy)
> > @@ -399,6 +399,11 @@ struct mips_cpu_info {
> >        if (TARGET_MCU)                                                      
> > \
> >     builtin_define ("__mips_mcu");
>       \
> >                                                                     \
> > +      if (TARGET_EVA)                                                      
> > \
> > +   {                                                               \
> > +     builtin_define ("__mips_eva");                                \
> > +   }                                                               \
> > +                                                                   \
> 
> This should be:
> 
>       if (TARGET_EVA)                                                 \
>       builtin_define ("__mips_eva");                                  \
> 
> You need to document the option too.
> 
Also done.
Okay, now?

2013-06-03  Catherine Moore  <c...@codesourcery.com>

        gcc/
        * config/mips/mips.opt (meva): New.
        * config/mips/mips.h (TARGET_CPU_CPP_BUILTINS):
        Define __mips_eva.
        (ASM_SPEC): Handle -meva.
        * doc/invoke.texi (meva):  Document.

gcc.eva.patch
Description: gcc.eva.patch