*ping* Alexander
2013/4/18 Patrick Marlier <patrick.marl...@gmail.com>: > Hi Alexander, > > On Thu, Apr 18, 2013 at 12:49 PM, Alexander Ivchenko <aivch...@gmail.com> > wrote: >> I'm trying it on linux/x86_64 on trunk. Testing just by adding -fpic >> to the dg-options: >> >> --- a/gcc/testsuite/g++.dg/tm/pr47746.C >> +++ b/gcc/testsuite/g++.dg/tm/pr47746.C >> @@ -1,5 +1,5 @@ >> // { dg-do compile } >> -// { dg-options "-fgnu-tm" } >> +// { dg-options "-fgnu-tm -fpic" } >> >> Here is the error msg: >> >> testsuite/g++.dg/tm/pr47746.C:20:14: error: unsafe function call 'void >> Building::load(InputStream*)' within 'transaction_safe' function > > Thanks! Now I understand the error (and I am able to reproduce it). :) > >> 4462| know what it will contain at runtime. */ >> 4463| if (cgraph_function_body_availability (node) < AVAIL_AVAILABLE) >> 4464+> return true; >> 4465| >> >> (gdb) p cgraph_function_body_availability (node) >> $54 = AVAIL_OVERWRITABLE >> >> Sure I can file a PR If you think that the test was not supposed to >> fail with -fpic > > I think your patch is OK but I cannot approve it since I am not a maintainer. > I CCed Richard since he is the one who can approve and knows the TM > implementation. > > Thanks, > -- > Patrick