On Fri, 2013-05-24 at 23:51 +0800, Chung-Ju Wu wrote: > 2013/5/23 Jakub Jelinek <ja...@redhat.com>: > > On Wed, May 22, 2013 at 08:30:35PM -0400, David Malcolm wrote: > >> The arrays of thresholds in gcc/bb-reorder.c appear not to have changed > >> since 2004 (in r80564). > >> > >> As part of my hope of quashing global state in gcc, I'd like to mark > >> them as const. > >> > >> Bootstrapped and tested on x86_64-unknown-linux-gnu against r199189, and > >> has the same test results as an unpatched bootstrap of that revision. > >> > >> OK to commit to trunk? > >> > >> 2013-05-21 David Malcolm <dmalc...@redhat.com> > >> > >> * bb-reorder.c (branch_threshold): make const > >> (exec_threshold): ditto > > > > The ChangeLog formatting is bad. After ): should always be a capital letter > > and the description should end with dot. So: > > > > * bb-reorder.c (branch_threshold): Make const. > > (exec_threshold): Ditto. > > > > instead. > > > > Jakub > > > Hi, David, > > There is a similar issue in the contrib/ChangeLog. > > > 2013-05-21 David Malcolm <dmalc...@redhat.com> > > * repro_fail: filter out "-ignore SIGHUP" from the spawn lines > > > It would be great if you can fix them to make formatting consistent. :)
I've fixed both of these (I hope) in r199302 Thanks Dave