Re: [PATCH] Refactor rtl_verify_flow_info and rtl_verify_flow_info_1

[Jeff Law]

On 05/15/2013 10:55 PM, Teresa Johnson wrote:

This patch refactors rtl_verify_flow_info_1 and rtl_verify_flow_info
by outlining the verification code into several different routines.
rtl_verify_flow_info_1 in particular was getting very large.

For the most part the functionality is exactly the same, although I
did eliminate one redundant check on the BLOCK_FOR_INSN pointer for
instructions inside blocks (both were in rtl_verify_flow_info_1, now in
rtl_verify_bb_pointers).

Bootstrapped and tested on x86_64-unknown-linux-gnu, and built cpu2006int
with profile feedback.

Ok for trunk?

Thanks,
Teresa

2013-05-15  Teresa Johnson  <tejohn...@google.com>

        * cfgrtl.c (verify_hot_cold_block_grouping): Return err.
        (rtl_verify_edges): New function.
        (rtl_verify_bb_insns): Ditto.
        (rtl_verify_bb_pointers): Ditto.
        (rtl_verify_bb_insn_chain): Ditto.
        (rtl_verify_fallthru): Ditto.
        (rtl_verify_bb_layout): Ditto.
        (rtl_verify_flow_info_1): Outline checks into new functions.
        (rtl_verify_flow_info): Ditto.

OK.

Please install.

Thanks,
Jeff